This is a forum where members new and old can come to ask questions and get info and opinions. It is not a place to advertise your business or have other forms of advertising, whether it be in your posts or signature.

All links in the forum will not be indexed by Search Engines and any unapproved forms of advertising or spam will be dealt with accordingly, deleted, and that member's account banned.

Forums

Overview » Ajax & JavaScript » Can someone Simplify / Improve this JavaScript code?
Reply

Can someone Simplify / Improve this JavaScript code?

Frank D.
Member



Since: 23 Jan 2003
Posts: 7
Posted 13 Feb 2009 14:06:19

Hi all,

I'm not a JavaScript expert and I hope someone can help me out with this. The code below is working properly (as long as i2 is no more than 5). Is there a way to simplify/improve the code? It would really help me out!

Many thanks in advance!

function setAccParam() {
	var paramString = "";
	var i2 = document.form1.AantalAcc.value; // total records of the recordset
	if(i2 == 1) {
	var param1 = document.form1.acc1.value;
	var param2 = "0";
	var param3 = "0";
	var param4 = "0";
	var param5 = "0";
	}
	else if(i2 == 2) {
	var param1 = document.form1.acc1.value;
	var param2 = document.form1.acc2.value;
	var param3 = "0";
	var param4 = "0";
	var param5 = "0";
	}
	else if(i2 == 3) {
	var param1 = document.form1.acc1.value;
	var param2 = document.form1.acc2.value;
	var param3 = document.form1.acc3.value;
	var param4 = "0";
	var param5 = "0";
	}
	else if(i2 == 4) {
	var param1 = document.form1.acc1.value;
	var param2 = document.form1.acc2.value;
	var param3 = document.form1.acc3.value;
	var param4 = document.form1.acc4.value;
	var param5 = "0";
	}
	else if(i2 == 5) {
	var param1 = document.form1.acc1.value;
	var param2 = document.form1.acc2.value;
	var param3 = document.form1.acc3.value;
	var param4 = document.form1.acc4.value;
	var param5 = document.form1.acc5.value;
	}
	paramString = ('&acc1=' + param1 + '&acc2=' + param2 + '&acc3=' + param3 + '&acc4=' + param4 + '&acc5=' + param5);
	top.location.href = ('testing.asp?srt=1' + paramString);
}

Hi all,

I'm not a JavaScript expert and I hope someone can help me out with this. The code below is working properly (as long as i2 is no more than 5). Is there a way to simplify/improve the code? It would really help me out!

Many thanks in advance!

function setAccParam() {
	var paramString = "";
	var i2 = document.form1.AantalAcc.value; // total records of the recordset
	if(i2 == 1) {
	var param1 = document.form1.acc1.value;
	var param2 = "0";
	var param3 = "0";
	var param4 = "0";
	var param5 = "0";
	}
	else if(i2 == 2) {
	var param1 = document.form1.acc1.value;
	var param2 = document.form1.acc2.value;
	var param3 = "0";
	var param4 = "0";
	var param5 = "0";
	}
	else if(i2 == 3) {
	var param1 = document.form1.acc1.value;
	var param2 = document.form1.acc2.value;
	var param3 = document.form1.acc3.value;
	var param4 = "0";
	var param5 = "0";
	}
	else if(i2 == 4) {
	var param1 = document.form1.acc1.value;
	var param2 = document.form1.acc2.value;
	var param3 = document.form1.acc3.value;
	var param4 = document.form1.acc4.value;
	var param5 = "0";
	}
	else if(i2 == 5) {
	var param1 = document.form1.acc1.value;
	var param2 = document.form1.acc2.value;
	var param3 = document.form1.acc3.value;
	var param4 = document.form1.acc4.value;
	var param5 = document.form1.acc5.value;
	}
	paramString = ('&acc1=' + param1 + '&acc2=' + param2 + '&acc3=' + param3 + '&acc4=' + param4 + '&acc5=' + param5);
	top.location.href = ('testing.asp?srt=1' + paramString);
}

Reply to this topic

Message
Reply

Live Support

On Sale

$53
$40

Advanced HTML Editor 3

Until February 8, 2012

$34
$21

Image Gallery Add-on

Until February 8, 2012

$40
$26

File Manager Add-on

Until February 8, 2012

Visit All Zones

The Dreamweaver ZoneThe Flash ZoneThe .NET ZoneThe Fireworks ZoneCFZone

Latest Extensions

Premium Articles

DMXzone Updater


Our Sponsors

Find Us on Facebook

Featured Extension

Extensions Yearly Subscription

Tired of purchasing many extensions just to finish up your project. Now we have a solution for you. For a small fee you have access to over 70 high-quality (all DMXzone extensions) and growing Dreamweaver extensions for a year period!

Additionally, we're working on many new ones, which will be available for every subscription holder when released!

Follow us on Facebook Follow us on twitter Subscribe to the RSS feed
Activate your free membership today | Login | Currency